You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I wanted something like this, but with traits with provided methods and required methods as well as perhaps extension traits, moving our code to something like extension trait provided methods. Thanks, i will think about it.
There are two major problems with this kind of bit-vec-extra.
Having two different apis adds conceptual overhead. It does not intuitively make sense.
Even if we added another api, the problem is stability. bitvec is on a stable version and if we do not offer similar high stability then it does not make sense to use our code. Our users should be very interested in stability.
@theroguevigilante My suggestion is to merely add a BitSlice feature through bit-vec = { version = "0.12", features = ["slice"] } and some other features, through bringing in some of the code from Payne's while keeping it all unstable for now.
Is BitSlice the only desirable feature @pczarn ? I think first things first we should know which features from the previous codebase are needed firsthand, regardless of the approach we are going to take.
Is BitSlice the only desirable feature @pczarn ? I think first things first we should know which features from the previous codebase are needed firsthand, regardless of the approach we are going to take.
The only frequently requested features are BitSlice and feature parity with std's Vec and [T]. Ferrilabs have perfect support for both. Whereas atomics with their concurrency are a niche use case of ferrilabs and we got only one request for them.
@pczarn In that case I think, it would be better to start with BitSlice and work our way from there. We can open a new pr for that and start working on it.
PS: Also we can discuss how exactly we are going to implement it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pczarn I propose this way too handle bitvec by payne, I have attached and example too that shows how exactly, it would work.