Delta bug fix#1115
Merged
Merged
Conversation
…ntryMapper,AssetMapper and refactor asset mapper components
🔒 Security Scan Results
⏱️ SLA Breach Summary
ℹ️ Vulnerabilities Without Available Fixes (Informational Only)The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:
✅ BUILD PASSED - All security checks passed |
vikrantraut-cstk
approved these changes
Jul 15, 2026
umesh-more-cstk
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Jira Ticket
MIGRATION-1091
📋 PR Type
📝 Description
What changed?
MAPPER_SEARCH_EMPTY_STATEconstant and wiredv2Features={{ isNewEmptyState: true }}+ acustomEmptyStateinto all three mapper tables so a zero-result search shows a consistent centered empty state.searchText/searchContentType), so the user can clear the search instead of being stranded on the full-page empty state.itemStatusMap+loadMoreItemsmodel with a single paginatedfetchAssets({ skip, limit, seedSelection })(same pattern as EntryMapper), addedv2Features.pagination,rowPerPageOptions, andminBatchSizeToFetch.seedSelectionpreserves the user's in-progress selection across search / page changes.tableHeightprop fromAssetMapperandcalcHeightfromentryAssetMapper..Table__centerWrapper; absolute-overlay centering for the field-mapper empty state; pinned the asset.Tableheight to remove the dead gap and keep the pagination bar + Save button visible; scoped the entry-mapper!importantheight rules with:not(.asset-mapper-container)so they stop overriding the asset table's sizing.cmsType/localPathinupload-api/src/config/index.jsonback to placeholders.Why?
Search on the mapper tables showed a bare/absent empty state and could trap the user with no way to clear the query. The asset table also used a heavy infinite-scroll fetch (up to 1000 rows at once) with layout bugs — dead space above the footer, clipped pagination bar, and a lost Save button. This standardizes the empty state, moves assets onto the same paginated model as entries, and fixes the associated layout issues.
🧩 Affected Areas
api— Node.js backendui— React frontendupload-api— Upload API serverdocker/docker-compose🧪 How to Test
Expected result:
A centered "No matching result found" empty state renders with the search box still available to clear. The asset table paginates server-side, selections persist across page/search changes until Save, and the table + pagination bar + Save button are all visible with no dead gap or overlap.
📸 Screenshots / Recordings
🔗 Related PRs / Dependencies
✅ Author Checklist
feature/,bugfix/, orhotfix/+ 5–30 lowercase chars.env/example.envupdated if new environment variables were addednpm test)README.md/ docs updated if behaviour changed👀 Reviewer Notes
fetchAssets/fetchDataand theseedSelectionselection-preservation logic.:not(.asset-mapper-container)so entry-mapper!importantheights stop fighting the asset table's venus-managed sizing — check both tables still size correctly.