Skip to content

Delta bug fix#1115

Merged
umesh-more-cstk merged 1 commit into
devfrom
bugfix/delta
Jul 15, 2026
Merged

Delta bug fix#1115
umesh-more-cstk merged 1 commit into
devfrom
bugfix/delta

Conversation

@yashin4112

Copy link
Copy Markdown
Contributor

🔗 Jira Ticket

Replace with your ticket link — required before requesting review.

MIGRATION-1091


📋 PR Type

  • ✨ Feature
  • 🐛 Bug Fix
  • 🔥 Hotfix
  • ♻️ Refactor
  • 🧹 Chore / Dependency Update
  • 📝 Documentation

📝 Description

What changed?

  • New "no matching result" empty state for search across ContentMapper, EntryMapper, and AssetMapper — added a shared MAPPER_SEARCH_EMPTY_STATE constant and wired v2Features={{ isNewEmptyState: true }} + a customEmptyState into all three mapper tables so a zero-result search shows a consistent centered empty state.
  • Kept the table + search box mounted on 0 results (render guards now include searchText / searchContentType), so the user can clear the search instead of being stranded on the full-page empty state.
  • EntryMapper: a no-match content-type search now keeps the selected content type and its entries instead of clearing the table.
  • Refactored the asset mapper from infinite scroll to server-side pagination — replaced the fetch-1000-rows + itemStatusMap + loadMoreItems model with a single paginated fetchAssets({ skip, limit, seedSelection }) (same pattern as EntryMapper), added v2Features.pagination, rowPerPageOptions, and minBatchSizeToFetch.
  • seedSelection preserves the user's in-progress selection across search / page changes.
  • Removed the now-unused tableHeight prop from AssetMapper and calcHeight from entryAssetMapper.
  • CSS fixes (index.scss): centered the search-empty state inside the venus .Table__centerWrapper; absolute-overlay centering for the field-mapper empty state; pinned the asset .Table height to remove the dead gap and keep the pagination bar + Save button visible; scoped the entry-mapper !important height rules with :not(.asset-mapper-container) so they stop overriding the asset table's sizing.
  • Reverted local dev cmsType / localPath in upload-api/src/config/index.json back to placeholders.

Why?

Search on the mapper tables showed a bare/absent empty state and could trap the user with no way to clear the query. The asset table also used a heavy infinite-scroll fetch (up to 1000 rows at once) with layout bugs — dead space above the footer, clipped pagination bar, and a lost Save button. This standardizes the empty state, moves assets onto the same paginated model as entries, and fixes the associated layout issues.


🧩 Affected Areas

  • api — Node.js backend
  • ui — React frontend
  • upload-api — Upload API server
  • docker / docker-compose
  • CI / GitHub Actions workflows
  • Environment variables / config
  • Other:

🧪 How to Test

  1. Run a delta migration (iteration 2+) to reach the Map Entry step (shows the Entries / Assets toggle).
  2. On each mapper table (Map Content Fields, Map Entry → Entries, Map Entry → Assets), type a search query that matches nothing.
  3. Clear the search and confirm the full list returns.
  4. On the Assets tab: page through results, change rows-per-page (10/30/50/100), toggle selections across pages, then Save.

Expected result:

A centered "No matching result found" empty state renders with the search box still available to clear. The asset table paginates server-side, selections persist across page/search changes until Save, and the table + pagination bar + Save button are all visible with no dead gap or overlap.


📸 Screenshots / Recordings

Before After

🔗 Related PRs / Dependencies


✅ Author Checklist

Complete this before moving the PR out of Draft.

  • Branch follows naming convention: feature/, bugfix/, or hotfix/ + 5–30 lowercase chars
  • Jira ticket linked above
  • Self-reviewed the diff — no debug logs, commented-out code, or TODOs left in
  • .env / example.env updated if new environment variables were added
  • No sensitive credentials or secrets committed
  • Existing tests pass locally (npm test)
  • New tests written (or not applicable — explain why)
  • README.md / docs updated if behaviour changed
  • Talisman pre-push scan passes (no secrets flagged)

👀 Reviewer Notes

  • Asset mapper moved from infinite scroll to pagination — worth a close look at fetchAssets / fetchData and the seedSelection selection-preservation logic.
  • Several CSS rules were scoped with :not(.asset-mapper-container) so entry-mapper !important heights stop fighting the asset table's venus-managed sizing — check both tables still size correctly.

Migration v2 · Docs · Issues

…ntryMapper,AssetMapper and refactor asset mapper components
@yashin4112
yashin4112 requested a review from a team as a code owner July 15, 2026 07:02
@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 1 0 10 ✅ Passed
🟠 High Severity 4 382 25 ✅ Passed
🟡 Medium Severity 0 1 500 ✅ Passed
🔵 Low Severity 1 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

ℹ️ Vulnerabilities Without Available Fixes (Informational Only)

The following vulnerabilities were detected but do not have fixes available (no upgrade or patch). These are excluded from failure thresholds:

  • Critical without fixes: 0
  • High without fixes: 382
  • Medium without fixes: 1
  • Low without fixes: 0

✅ BUILD PASSED - All security checks passed

@umesh-more-cstk
umesh-more-cstk merged commit 73e02eb into dev Jul 15, 2026
9 checks passed
@umesh-more-cstk
umesh-more-cstk deleted the bugfix/delta branch July 15, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants