fix(emphasis): hard-break sentinel breaks punctuation-closed bold#238
Merged
Merged
Conversation
Punctuation-closed `**`/`*`/`~~` before a hard break failed CommonMark right-flanking because the `\uFFFE` sentinel is neither whitespace nor punctuation, so closers stayed literal. Count the sentinel as whitespace. Co-authored-by: Jonathan Kingston <jonathanKingston@users.noreply.github.com>
jonathanKingston
marked this pull request as ready for review
July 23, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hard breaks are replaced with a
\uFFFEsentinel before emphasis runs so newlines aren’t flattened away. That sentinel was neither whitespace nor punctuation for CommonMark flanking checks, so a closer after punctuation (?**/!**/.**+ hard break) failed right-flanking and left the markers literal.What Copse does now
Is pulling it possible?
…would bold the first line and leave
**on the second. Soft breaks and same-line closers were unaffected.Fix
Treat the hard-break sentinel as flanking whitespace in
isFlankingWhitespace(a hard break stands in for a newline). This also fixes the same pattern for*emphasis and GFM~~strikethrough, which share the flanking helpers.Test plan
renderer.test.tsfor punctuation-closed strong/em/strike before two-space and backslash hard breaksrenderer.test.ts,inline-emphasis.test.ts,inline-strikethrough.test.ts