fix(auth): show concise identity with whoami --quiet - #122
Merged
Merged
Conversation
Co-Authored-By: coreplane-switchboard[bot] <318072483+coreplane-switchboard[bot]@users.noreply.github.com>
justinhelmer
approved these changes
Oct 3, 2026
justinhelmer
left a comment
Contributor
There was a problem hiding this comment.
Reviewed exact head 142b304 against cli#37, the flag parser, credential resolver and output formatter. Quiet text prints one identity line; ordinary text and JSON preserve their prior behavior. The test-only follow-up explicitly overrides stored OAuth credentials; its signed-in full suite passed 549/549, and all three current-head CI jobs passed. LGTM for the CLI change. Installer rerun wiring and a containing CLI release remain separate gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by justin · Thread
polylane auth whoami --quiet --output textnow prints a single signed-in identity line. Installer reruns can show who is signed in without dumping the full account record.Why: cli#37 records that installer reruns lost their identity cue when the noisy status dump was removed in polylanedotcom#107; the launch-polish tracking record is nominal#1165.
Where to look
Feedback wanted: Is the explicit
--output text --quietinterface the right installer-facing contract, given JSON remains the piped default?Risk: Limited to
auth whoamiquiet text rendering; if wrong, installer identity display or automation consuming it changes. Revert this commit to restore the old output.Verified: 4 focused tests, scoped typecheck, ESLint and diff whitespace check passed; installer wiring and CI matrix remain human/CI-gated.
Decisions (1)
--output lineformat: quiet is already a global option, while--outputis limited to text and JSON; JSON consumers must retain the full object.Validation (6 criteria)
npx tsx --test test/auth-whoami.test.tsexit 0; tests 4, pass 4, fail 0.NODE_OPTIONS=--max-old-space-size=6144 npx tsc --noEmit -p tsconfig.jsonexit 0.npx eslint src/commands/auth/whoami.ts test/auth-whoami.test.tsexit 0.git diff --check origin/main...HEADexit 0.run_checkrefused baseline with command_refused and no completion receipt; no baseline pass asserted.For agents
Rebased onto origin/main before work and immediately before push (no conflicts). Ignored src/generated was regenerated with
npm run codegenafter the prepared checkout lacked it; do not commit generated output.node --test --experimental-test-module-mocks --import tsxwas refused by recorded check tooling; the focused test instead ran withnpx tsx --test. Installer itself lives in polylanedotcom and needs a separate integration change.🤖 Generated with Claude Code