Repository navigation
Flake batch 39: deferred GitHub read fixture gets a 30 s completion wait - #1356
Merged
Merged
Conversation
… wait github_read_restriction_responsiveness waited 1 s for a fixture read that completes on a worker thread, and main's Linux unit run timed out on it under load. The test checks that the read is deferred, not its latency, so this is a positive wait and takes the generous budget. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
logging::tests::subc_terminal_mirror_does_not_wait_for_stderr waited 1 s for a log line to persist while stderr is held. A loaded Windows runner missed that (run 41624863622). stderr is released only after the wait, so a write that blocked on it still fails the test. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
subc::tests::failed_database_open_refuses_tools_and_rebind_retries_persistence sent its read with a 1 s client deadline; a loaded Windows runner admitted it after the deadline, so it was refused before running (run 41624863622). A read blocked behind the open would still never finish, so the check holds. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
status_names_an_unreachable_backend_before_the_build_reaches_it polled 5 s for the backend verdict; a refused connect on a loaded Windows runner took longer (run 41628184380). The consent fixture's next frame waited 10 s and a loaded macOS runner missed it. Both are positive waits: raised to 30 s. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only timing fixes for positive waits that loaded runners missed. No product code changes.
GitHub read deferral (
cache_miss_repeat_read_and_image_download_paths_use_deferred_responses): waited 1 s for a deferred fixture read; raised to 30 s. It turned main red on Linux. The two short waits that assert nothing arrives stay short.Terminal log mirror (
subc_terminal_mirror_does_not_wait_for_stderr, Windows): waited 1 s for the log line to persist while stderr was held; raised to 30 s. stderr is released only after the wait, so a write that blocked on it still fails.Read during a database open (
failed_database_open_refuses_tools_and_rebind_retries_persistence, Windows): the read used a 1 s client deadline and slow admission refused it before it ran; raised to 30 s. A read stuck behind the failed or gated open would never finish, so the check holds.Refused backend probe (`status_names_an_unreachable_backend_before_the_build_reaches_it`, Windows): polled 5 s for the backend verdict; a refused connect on a loaded Windows runner can take seconds. Raised to 30 s.
Consent fixture frame (`audit_started_shell_is_killed_by_scope_cleanup_and_never_not_started`, macOS): waited 10 s for the next frame; raised to 30 s. A frame that never arrives still fails.
Verified: 112 database-open, logging and GitHub-read tests, plus 44 backend-status and consent tests; formatting; Windows check.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.