Repository navigation
Inspect: bound the JS/TS dead-code and unused-export readers (#1337 follow-up) - #1361
Merged
Merged
Conversation
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
) The owner changed the JS/TS contract: generated and minified files no longer contribute findings or import edges, rather than being reported in generated buckets. Update those explicit expectations while preserving handwritten findings, deterministic/cached parity, and legacy classification fallback. The preceding fail-first commit demonstrated all four new admission regressions failing before this change. Keep one cache epoch bump (43 to 44) for the combined policy. Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
Co-authored-by: alfonso-aft <289616620+alfonso-aft@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1340 (issue #1337). The JavaScript/TypeScript dead-code and unused-export readers (the Oxc engine,
dead_code.rs,unused_exports.rs) still read every source file whole, so one huge generated bundle could still push AFT's memory far up. This applies Ufuk's ruling for these two checks:file_kindclassifier (name first, then at most an 8 KiB header) and left out of the graph, imports included.Real-repository check (AFT's packages, opencode at
f7d5a1cb, protobuf-es at9ef472d8, uncapped scans, classifier on vs off): excluding generated files added no new findings in any of the six repository/category results; it removed the generated-only findings (e.g. protobuf-es dead code 2,301 → 0, unused exports 2,544 → 0). Headline counts are unchanged. Report and data:.cortexkit/internal-docs/investigations/graph-source-admission/.Tests: fail-first regressions for the 4 MiB limit (a 1.5 MiB handwritten file is read; a 5 MiB file is a named gap with zero full-source reads) and for generated/minified exclusion (zero full reads, header-only classification). Gate on current main: 530 inspect library tests, 377 inspect integration tests, formatting and the Windows check.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.Summary by cubic
Bounds the JS/TS dead-code and unused-export readers so one huge generated bundle can no longer push AFT memory up.
Migration
Written for commit 50f819c. Summary will update on new commits.