Add latency charts to Magma dashboard - #150
Open
rohansuri wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds latency and OS allocation-stall monitoring to the Magma node/bucket dashboard.
Changes:
- Adds GET and SET p50–p99.9 latency charts.
- Adds an OS allocation-stall rate panel.
- Introduces Latency and OS dashboard sections.
Suppressed comments (1)
dashboards/magma-nodebucket.json:1789
- This OS section has the same layout bug: using
panel.jsonand overridingtypeleaves the row withw: 12/h: 12, and the dashboard generator lays it out using those panel dimensions. As a result, the OS row is not a full-width section divider. Use the row template (_base: "row") here as well.
"_base": "panel",
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ] | ||
| }, | ||
| { | ||
| "_base": "panel", |
The row entries in magma-nodebucket.json were built from panel.json and
only overrode "type", so merge_meta_into_template left gridPos at the
panel template's {w: 12, h: 12} rather than the row template's
{w: 24, h: 1}. make_dashboard lays panels out using that grid position,
so each section divider was packed as a half-width, 12-unit-tall block
beside the preceding panel, which also pushed the first panel of every
section to x=12.
Build them from the row template instead. "type" is dropped as row.json
already sets it, matching how kv-cluster.json declares rows.
All six rows now lay out at x=0 w=24 h=1, no panel is left off the
two-column grid, and the dashboard is 19 grid units shorter.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.