Repository navigation
Conversation
- build amd64 and arm64 natively, push by digest - merge digests into one ghcr.io/cowprotocol/cow-cli manifest - add slim debian runtime image with curl and jq - build on cli-reclaim-buffer until it lands in main Refs: DEV-481
- short-lived jobs don't need signal forwarding or zombie reaping - use docker run --init for interactive runs Refs: DEV-481
reclaim-buffers derives PDAs with the solana cli and prices dust with bc. Adds both to the cow-cli image (solana v4.0.3, amd64-only since agave has no arm64 linux build) so buffer reclaim runs in-cluster.
The cli-reclaim-buffer trigger was temporary until the image landed in main (see #190). Co-authored-by: Assem Hasna <assem@cow.fi> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
update: preserving authorship is difficult and contrary to the pattern we have always followed in this repo up to this point, so we are going to squash merge to keep it simple. |
fedgiac
approved these changes
Oct 19, 2026
fedgiac
left a comment
fedgiac
left a comment
Contributor
There was a problem hiding this comment.
To be honest it's a bit confusing and I think it could be made simpler. But overall it doesn't matter much for our purposes as long as it works.
Co-authored-by: Federico Giacon <58218759+fedgiac@users.noreply.github.com>
Co-authored-by: Federico Giacon <58218759+fedgiac@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brings the
cowCLI Docker image and itsCLI imageworkflow intomain. This is all @glokos's work: it buildsghcr.io/cowprotocol/cow-clifor amd64 and arm64, then merges both into one manifest tagged with the sha and branch/tag. The image includes the Solana CLI andbcthat the buffer-reclaim script needs.The first three commits are Assem's original commits from #190 and #205, cherry-picked unchanged. The last one drops the temporary
cli-reclaim-bufferpush trigger, which #190 said to remove once the image landed inmain.Motivation
#190 and #205 were merged into the reclaim stack's branches instead of
main, so the image work now shows up inside #206/#207/#204 and makes them harder to review. Landing it here on its own means those PRs only show CLI changes once they're rebased.Considerations
Credit
Please rebase-merge this PR rather than squash it, so that Assem's commits land on
mainwith him as the author. The trigger commit lists him as co-author too.Parity with the stack
.github/workflows/cli-image.ymlandtest-cli/Dockerfileon this branch are byte-for-byte identical to the versions oncli-reclaim-buffer(#204), so rebasing the stack ontomainafterwards should drop these files from its diff.How to test
This PR should be the same as those already included in the buffer reclaim changes we eventually expect to merge:
Once merged, any branch that contains the workflow file can be built by hand, via Actions → CLI image → Run workflow (pick the branch under "Use workflow from") or:
Unfortunately it doesn't seem to be possible to workflow dispatch until this is actually merged, but an example of this dockerfile generating a successful build though CI is already on its actions page.
The image is tagged
cow-cli:<branch>(slashes become-) andcow-cli:sha-<short>.🤖 Generated with Claude Code