Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iter_tree_entries()anditer_tree_files()documenton_erroras the filesystem-error handler (andNoneas ignoring filesystem errors), but an error opening a directory withos.scandir()bypasses the handler. A directory removed before scanning or an unreadable child therefore aborts the entire walk, even when the caller supplies a handler to log and continue.Catch errors from opening each directory in both walkers, remove that directory from the active-ancestor memo, call the handler when present, and return from that subtree. Exceptions raised by the handler still propagate. Successful scanning and recursive-loop detection are unchanged. This is intentionally limited to opening a directory, not a general rewrite of entry inspection or iteration.
Tests
PermissionErroratos.scandir, rather than relying on platform-specific permission manipulation.python -m unittest discover -t . -s tests/is OK (225 test methods; 398 skipped cases/subcases). Unmodified baseline: 223 methods, same 398 skips. Optional re2/hyperscan backends and unsupported symlink cases are skipped; no full backend/platform matrix or docs-build claim.git diff --checkpasses. Updated changelog source and generated changelog together.AI assistance disclosure: this patch and its regression tests were developed with OpenAI Codex assistance; the behavior above was reproduced and tested locally.