Suppression file name cache.#8684
Open
MartinBP wants to merge 2 commits into
Open
Conversation
Implement a file name cache per suppression to avoid calling PathMatch::match again and again for the same suppression and file name combination.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement a file name cache per suppression to avoid calling PathMatch::match again and again for the same suppression and file name combination.
Local benchmark running cppcheck with misra c-2012 has been performed.
Before
10min 34sec
After
1min 36sec
In this test it was a few header files producing the majority of the error messages, which is why the cache speeds it up by a lot.