Skip to content

[6.x] Prevent condition builder change listener fallthrough - #19774

Merged
riasvdv merged 2 commits into
6.xfrom
extract/19665-condition-builder-change-retry
Oct 1, 2026
Merged

riasvdv merged 2 commits into
6.xfrom
extract/19665-condition-builder-change-retry

Conversation

@riasvdv

@riasvdv riasvdv commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Description

Declares change on ConditionBuilderControl so FieldNode's listener does not fall through to the inner builder and receive a raw condition value. The existing update:value event still sends the value with the discrete change kind. Condition editing, validation, and the custom element event bridge retain their existing behavior.

 defineEmits<{
   (event: 'update:value', value: ConditionConfig, kind: 'discrete'): void;
+  (event: 'change'): void;
 }>();

Related issues

riasvdv and others added 2 commits October 1, 2026 10:13
Co-authored-by: Nathaniel Hammond <nathaniel@pixelandtonic.com>
Co-authored-by: Nathaniel Hammond <nathaniel@pixelandtonic.com>
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

📚 Storybook previews

@craftcms/ui — open Storybook

No changed components detected in this Storybook.

resources/js — open Storybook

No changed components detected in this Storybook.

@riasvdv
riasvdv merged commit f4fd85b into 6.x Oct 1, 2026
23 checks passed
@riasvdv
riasvdv deleted the extract/19665-condition-builder-change-retry branch October 1, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant