Skip to content

[6.x] Fix card designer preview element type - #19776

Merged
riasvdv merged 3 commits into
6.xfrom
extract/19665-card-designer-preview-type-retry
Oct 1, 2026
Merged

riasvdv merged 3 commits into
6.xfrom
extract/19665-card-designer-preview-type-retry

Conversation

@riasvdv

@riasvdv riasvdv commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Description

Card designer preview requests omitted the element type because it is stored in designer settings rather than the serialized layout config. Include it in the preview request so the backend can render the sample element, while preserving generated fields and the saved layout value.

Extracts only the card preview request fix from #19665.

riasvdv and others added 2 commits October 1, 2026 10:14
Co-authored-by: Nathaniel Hammond <nathaniel@pixelandtonic.com>
Co-authored-by: Nathaniel Hammond <nathaniel@pixelandtonic.com>
@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

📚 Storybook previews

@craftcms/ui — open Storybook

No changed components detected in this Storybook.

resources/js — open Storybook

No changed components detected in this Storybook.

…igner-preview-type-retry

# Conflicts:
#	CHANGELOG.md
@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown

This PR had conflicts with 6.x. Claude attempted an automatic resolution and pushed a merge commit. Please review the merge commit carefully before approving/merging.

Claude's response

The merge is done and committed as c6b15f2. It hasn't been pushed.

CHANGELOG.md was the only file with a conflict, and it wasn't ambiguous. Both sides had added a different bug-fix line at the same spot in the list:

I kept both lines, this branch's first, so no CONFLICT-REVIEW comment was needed. The other changed files came in from 6.x without conflicts, and I didn't edit them.

Changed

  • Combined the two changelog entries in CHANGELOG.md, staged it, and ran git commit --no-edit to finish the merge.

Found

  • Nothing.

@riasvdv
riasvdv merged commit 57ace48 into 6.x Oct 1, 2026
23 of 25 checks passed
@riasvdv
riasvdv deleted the extract/19665-card-designer-preview-type-retry branch October 1, 2026 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant