[6.x] Add form-page sidebar controls - #19778
Merged
Merged
Conversation
Share metadata details content with the element editor. Co-authored-by: Nathaniel Hammond <nathaniel@pixelandtonic.com>
Co-authored-by: Nathaniel Hammond <nathaniel@pixelandtonic.com>
📚 Storybook previews@craftcms/ui — open Storybook Changed components: resources/js — open Storybook No changed components detected in this Storybook. |
Keep the large source lists and filtering assertions while limiting rendered options to ten, avoiding CI timeouts during option registration. Co-authored-by: Nathaniel Hammond <nathaniel@pixelandtonic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Generic
Form.vuepages can now supply asidebarFormandmetadataHtmlfor the details column. Main and sidebar controls participate in one save, with validation, baseline updates, and password-confirmation comparisons covering both renderers. Duplicate top-level keys use sidebar values, matching the source implementation.The shared
MetadataDetailsContentrenders controls above metadata for both generic form pages and element editors, preserving the element editor's autosave, workflow locks, and tabs.Extracts the sidebar controls from #19665 without its admin-table or alternate-action changes.
The existing combobox tests timed out repeatedly in CI while rendering 150 custom options. Their fixtures now use a configured cap of 10 while retaining the hundreds-entry source lists and successive-filter coverage.