Skip to content

Make searchClient a separate bean so Studio context can override to avoid duplicating instances#855

Open
jmendeza wants to merge 1 commit into
craftercms:support/4.xfrom
jmendeza:bugfix/1265-e-5x
Open

Make searchClient a separate bean so Studio context can override to avoid duplicating instances#855
jmendeza wants to merge 1 commit into
craftercms:support/4.xfrom
jmendeza:bugfix/1265-e-5x

Conversation

@jmendeza

Copy link
Copy Markdown
Member

Make searchClient a separate bean so Studio context can override to avoid duplicating instances
https://github.com/craftersoftware/craftercms/issues/1265

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The Spring services context extracts OpenSearchClientFactory construction into a dedicated searchClient bean and wires crafter.searchClient to reference it. Existing search-related aliases remain unchanged.

Changes

OpenSearch client wiring

Layer / File(s) Summary
Dedicated OpenSearch client configuration
src/main/resources/crafter/engine/services/main-services-context.xml
Adds a top-level searchClient bean with OpenSearch connection settings and changes crafter.searchClient to use that bean.
Estimated code review effort: 2 (Simple) ~10 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly summarizes the main change: splitting searchClient into a separate bean for Studio overrides.
Description check ✅ Passed The description covers the change and includes the ticket reference, so it is mostly complete.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jmendeza
jmendeza marked this pull request as ready for review July 16, 2026 18:43
@jmendeza
jmendeza requested a review from sumerjabri as a code owner July 16, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant