Unify URL logic to simplify the code - #99
Draft
bodowd wants to merge 4 commits into
Draft
Conversation
x64_linux is available under the platform specific url: https://cdn.crate.io/downloads/releases/cratedb/x64_linux/
bodowd
force-pushed
the
unify-url-logic
branch
from
August 10, 2026 20:57
25bbf56 to
d9d6bd0
Compare
fromVersion now will automatically figure out the correct url to download a release from based on the system platform
bodowd
force-pushed
the
unify-url-logic
branch
3 times, most recently
from
August 11, 2026 11:41
c4b8262 to
80b42b4
Compare
The test can fail if the expected cratedb release's tar.gz has not been downloaded yet. We now make sure that the expected version has been downloaded so that it is available locally for `fromFile`
bodowd
force-pushed
the
unify-url-logic
branch
from
August 11, 2026 12:18
b373ec5 to
bc409c4
Compare
Contributor
Author
|
Note for later: Should revisit this in future. There are old tests that test against CrateDB 3.0.x There have been breaking changes since and the tests in this repo are expecting functionality that is no longer in the latest release. The tests will need to be adapted for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Related to crate/jmx_exporter#102
We can simplify the logic in the URL code.
x64_linux is available under the platform specific url: https://cdn.crate.io/downloads/releases/cratedb/x64_linux/
See this comment: #96 (comment)
Checklist