Repository navigation
Conversation
Strix Security Review✅ No open security findings. PR summary: This PR fixes `GithubSearchTool` so that `content_types` supplied at construction time is preserved (forwarded through to `RagTool`'s initializer) and used by the eager repo-indexing call instead of being dropped. It also adds a regression test asserting the configured content types reach the adapter metadata. Review summaryThe change is confined to Review 1 on this PR · Reviewed by Strix |
|
Thanks for the pull request. First-time contributors need an associated open issue before we can review a PR.
See the contributing guide. |
Related issue
Fixes #8888
Summary
Verification
Additional context
Note
Low Risk
Small behavioral fix in a search tool constructor and init path; covered by an added unit test.
Overview
Fixes
GithubSearchToolsocontent_typespassed at construction are stored on the instance and used when indexing a repo, including when the repo is added later viaadd()rather thangithub_repoat init.Constructor changes:
content_typesis forwarded intosuper().__init__via kwargs so Pydantic keeps the configured list. When a repo is fixed at init,addruns for anygithub_repo(not only when both repo andcontent_typesare set) and passesself.content_typesinstead of the raw constructor argument.A test asserts that a tool built with
content_types=["repo"]and no initial repo still passes["repo"]into the adapter whenadd(repo=...)is called.Reviewed by Cursor Bugbot for commit c5e037b. Bugbot is set up for automated code reviews on this repo. Configure here.