Conversation
Signed-off-by: Hesham Ahmed <hesham@micronisus.com>
hsahmed
force-pushed
the
fix/default-priv-schema-role
branch
from
September 14, 2026 03:36
6d4107f to
292a1cb
Compare
Author
|
@fernandezcuesta can you please review this PR (or the other one for the same issue #459). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
DefaultPrivileges reconciler's observe query didn't filter on schema and targetrole name thus returning Ready/Sync for DefaultPrivileges targeting different schemas and target roles as long as one default privilege existed for the role.
This PR updates the select query to make sure the specific DefaultPrivilege exists before returning Ready/Synced.
Fixes #458
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Code has been tested manually, the change is simple and the issue is easily reproducible.