Make generated Go models satisfy client.Object/client.ObjectList

[erikmiller-gusto]

Description of your changes

features.generateGoRuntimeObjects (off by default) makes generated root types implement runtime.Object, but that's not enough to use them with sigs.k8s.io/controller-runtime's client.Client. client.Object also requires metav1.Object, whose method signatures are fixed by apimachinery (types.UID, metav1.Time, []metav1.OwnerReference, ...). The locally-generated ObjectMeta mirror type can't satisfy those signatures no matter what methods get added to the root type.

This PR:

• Redirects io.k8s.apimachinery.pkg.apis.meta.v1 to the real k8s.io/apimachinery/pkg/apis/meta/v1 package when the flag is on, instead of generating a local mirror. Metadata's Go type becomes the real ObjectMeta/ListMeta.
• Generates metav1.Object methods on root types and metav1.ListInterface methods on <Kind>List types, delegating to the real Metadata field.
• Fixes <Kind>List.Items, generated as *[]Kind (pointer-to-slice). k8s.io/apimachinery/pkg/api/meta's GetItemsPtr, used by client.List, the fake client, and the informer cache, requires a literal slice.
• Registers metav1.AddToGroupVersion so client.List with query options and client.Watch work.
• Fixes collectStructTypes, which didn't resolve type A = B aliases back to the underlying struct. A <Kind>List's Items element is always a qualified-name alias for the root type (type CoAcmePlatformV1Alpha1Foo = Foo), so it was treated as a scalar and DeepCopy fell back to a shallow copy that shared item pointers with the original.
• Updates the generated module's go.mod/go.sum. The real k8s.io/apimachinery/pkg/apis/meta/v1 package pulls in transitive dependencies (golang.org/x/net, golang.org/x/text, gopkg.in/inf.v0, k8s.io/utils, sigs.k8s.io/randfill) nothing previously imported, captured from a real go mod tidy run.

Breaking change to generateGoRuntimeObjects's output, documented in cmd/crossplane/config/help/config.md. The flag is off by default and wasn't usable as a client.Object before this, so there's no migration path beyond regenerating models.

Tested with:

• Unit tests in internal/schemas/generator/runtimeobject_test.go covering the metav1.Object/ListInterface method split, the Items fix, and the alias-resolution fix.
• A compile-gate test (-tags compilegate) that builds a separate consumer module requiring sigs.k8s.io/controller-runtime via a replace directive at the materialized models directory, so controller-runtime never touches the generated module's own go.mod. It exercises a real fake client (Create/Get/List), a DeepCopy independence check against the real generated XAccountScaffoldList type, and a runtime.NewParameterCodec round-trip proving the AddToGroupVersion registration.

Opened as a draft for early feedback before marking ready for review.

I have:

• Read and followed Crossplane's contribution process.
• Run ./nix.sh flake check to ensure this PR is ready for review.
• Added or updated unit tests.
• Linked a PR or a docs tracking issue to document this change.
• Added backport release-x.y labels to auto-backport this PR.

[coderabbitai]

Warning

Review limit reached

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: crossplane/cli/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 35c85ad1-9330-4da5-9bdd-b6c2bf376d30

📥 Commits

Reviewing files that changed from the base of the PR and between 3e5d853 and 383fbf7.

📒 Files selected for processing (9)

• cmd/crossplane/config/help/config.md
• internal/config/config.go
• internal/schemas/generator/go.go
• internal/schemas/generator/go_test.go
• internal/schemas/generator/interface.go
• internal/schemas/generator/runtimeobject.go
• internal/schemas/generator/runtimeobject_compilegate_test.go
• internal/schemas/generator/runtimeobject_integration_test.go
• internal/schemas/generator/runtimeobject_test.go

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}