fix: encode parentheses in image src#86
Open
greymoth-jp wants to merge 1 commit into
Open
Conversation
An <img> whose src contains parentheses produced an unescaped markdown destination: `<img src="a)b.png">` became `b.png)`, which a parser reads as an image of `a` followed by the literal text `b.png)`. Encode the parens in the image src, mirroring the guard the link translator already applies to href.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
imgtranslator writes thesrcattribute straight into the markdown destination with no escaping. When the URL contains a parenthesis, the output is broken markdown.For example:
currently produces:
A parser reads the first
)as the end of the destination, so this renders as an image ofhttp://example.com/foofollowed by the literal textbar.png).The
atranslator already guardshrefagainst this (added in #26). This applies the same protection to imagesrcby percent-encoding(and).I kept the encoding to parentheses only. The link rule also encodes
_and*, but those are not special inside a destination, and encoding them would change common image URLs (the existingkeepDataImagestest expectsnormal_img.jpgto stay as-is).The
Image (img)test now covers a parenthesised URL.