Fix duplicate *b* bookmark-source links on verses - #1380
Merged
karlkleinpaste merged 1 commit intoAug 16, 2026
Conversation
build_tag_color_map() carried a manual hyphenated-range expansion (searching the raw bookmark key text for ":<verse>-<digits>") that predated the fix to BackEnd::parse_verse_list() itself. Now that parse_verse_list() properly expands a range like "1Tim 2:9-12" into ne list element per verse, this leftover manual expansion ran a second time for every verse after the range's start, appending a second, duplicate bookmark-source entry into the (now append-based, not first-wins) tag_color_map for those verses -- producing two *b* links instead of one on verses 10-12 while verse 9 correctly showed only one. Remove the now-redundant manual expansion; parse_verse_list() alone is sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix duplicate b bookmark-source links on verses after a range's start build_tag_color_map() carried a manual hyphenated-range expansion (searching the raw bookmark key text for ":-") that predated the fix to BackEnd::parse_verse_list() itself. Now that parse_verse_list() properly expands a range like "1Tim 2:9-12" into ne list element per verse, this leftover manual expansion ran a second time for every verse after the range's start, appending a second, duplicate bookmark-source entry into the (now append-based, not first-wins) tag_color_map for those verses -- producing two b links instead of one on verses 10-12 while verse 9 correctly showed only one.
Remove the now-redundant manual expansion; parse_verse_list() alone is sufficient.