Fix for #921: Caret in the text - #1382
Merged
Merged
Conversation
…crosswire#921) Restricted to TEXT_TYPE and COMMENTARY_TYPE panes: enabling caret browsing on every WkHtml instance simultaneously (dictionary, sidebar, etc.) was found to interfere with keyboard caret navigation (Down/Page_Down) in the active pane, even though the affected pane kept receiving every key event normally.
Discovered while investigating crosswire#921: wrapping the chapter title and intro material (which legitimately contain block-level <div>/<h2> elements) inside an inline <a name=...> tag is invalid HTML. WebKit's HTML5 parser silently fragments/duplicates the <a> element via the adoption agency algorithm to recover, which can leak inline styles (e.g. italics) past their intended scope in some chapters. Does not fully resolve the italics-leak issue on its own (a deeper cause was also found in cross-chapter OSIS section boundaries and in getVerseBefore()'s tag-crossing markup); tracked separately.
Contributor
Author
|
Oops, I just realized I synced the caret branch with master! I hope that doesn't cause any conflicts... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable WebKit caret browsing in Bible text and commentary panes (fixes #921)
Restricted to TEXT_TYPE and COMMENTARY_TYPE panes: enabling caret
browsing on every WkHtml instance simultaneously (dictionary,
sidebar, etc.) was found to interfere with keyboard caret navigation
(Down/Page_Down) in the active pane, even though the affected pane
kept receiving every key event normally.