Skip to content

fix(github-plugin): encode repo paths in raw.githubusercontent.com URLs #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deanrie wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(github-plugin): encode repo paths in raw.githubusercontent.com URLs #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions apps/cursor/src/lib/github-plugin/parse.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,25 @@ export async function fetchWithRateLimit(
*/
export type FetchOptions = { maxWaitMs?: number };

/**
* Raw-content URL for a repo path. Tree paths arrive unencoded, so a `#`
* would start a URL fragment, a `?` a query, and a `%` a broken escape; each
* segment is encoded while the `/` between them is kept.
*/
function rawGitHubUrl(owner: string, repo: string, path: string): string {
const encodedPath = path
.split("/")
.map((segment) => encodeURIComponent(segment))
.join("/");
return `https://raw.githubusercontent.com/${owner}/${repo}/HEAD/${encodedPath}`;
}

async function fetchGitHubFile(
owner: string,
repo: string,
path: string,
): Promise<string | null> {
const url = `https://raw.githubusercontent.com/${owner}/${repo}/HEAD/${path}`;
const url = rawGitHubUrl(owner, repo, path);
try {
const res = await fetch(url, { cache: "no-store" });
if (!res.ok) return null;
Expand Down Expand Up @@ -593,7 +606,7 @@ export async function parseGitHubPlugin(
logo = manifest.logo;
}
} catch {
logo = `https://raw.githubusercontent.com/${owner}/${repo}/HEAD/${manifest.logo.replace(/^\.?\//, "")}`;
logo = rawGitHubUrl(owner, repo, manifest.logo.replace(/^\.?\//, ""));
}
}

Expand Down