Repository navigation
fix(vanta): require the region host used in the server URL - #822
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Vanta plugin builds its MCP URL as
https://${VANTA_MCP_HOST}/mcp, butVANTA_MCP_HOSTis not invariables.required. Cursor can save the plugin with no region selected, which leaves a URL it cannot resolve, so the Vanta server never connects.VANTA_MCP_HOSTis now required. The plugin version is 1.1.1 and the changelog records the setup change. The host enum is the same three regional hosts.Validation: On origin/main,
node --test third_party/vanta/mcp-url.test.mjsfailed withVANTA_MCP_HOST is interpolated into the server URL but is not required. After this change the same test passes.node scripts/validate-plugins.mjsreported all plugins valid,node scripts/generate-pstack-harness-trees.mjs --checkreported the harness tree up to date, andgit diff --checkwas clean.Note
Low Risk
Plugin metadata and a regression test only; no runtime auth or application logic changes.
Overview
Fixes a Vanta plugin setup bug where
VANTA_MCP_HOSTcould be omitted even though the MCP URL ishttps://${VANTA_MCP_HOST}/mcp, which let Cursor save an unresolved URL and block the connection.VANTA_MCP_HOSTis now listed invariables.requiredinplugin.json, the plugin is bumped to 1.1.1, and the changelog notes the change. A newmcp-url.test.mjsasserts every variable interpolated into the server URL is required and that the regional host enum is unchanged.Reviewed by Cursor Bugbot for commit 14de572. Bugbot is set up for automated code reviews on this repo. Configure here.