Repository navigation
fix(pstack): give poteto-mode a deslop fallback without cursor-team-kit - #853
Open
JaxonWright wants to merge 1 commit into
Open
JaxonWright wants to merge 1 commit into
JaxonWright wants to merge 1 commit into
Conversation
poteto-mode and three of its playbooks run /deslop before each commit, but /deslop ships in cursor-team-kit. With only pstack installed, nothing told the agent what to do, so it could skip the cleanup. The trigger now says to make the same pass over the branch's diff by hand, using deslop's focus areas. The guide says poteto-mode does this itself. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude Code on behalf of @JaxonWright.
Problem
poteto-mode and three of its playbooks tell the agent to run
/deslopbefore each commit./deslopships incursor-team-kit, so a user who installs only pstack doesn't have it. The agent-facing text never says what to do then, so the agent can skip the cleanup and only note the skip. A Claude Code session with pstack but notcursor-team-kitdid exactly that.A fallback already exists, but only in
docs/guide/05-build-and-clean.md. poteto-mode never links to the guide, so agents don't see it./unslopdoesn't fill the gap. It cleans prose, and/deslopcleans code.Change
/desloptrigger inpoteto-mode/SKILL.mdnow says what to do without the plugin. The agent makes the same pass over the branch's diff by hand, using the focus areas fromcursor-team-kit/skills/deslop/SKILL.md. The playbooks that say "run/deslop" inherit this from the trigger, so they don't change.harness/pstack/claude-code/is regenerated.Scope
deslopinto pstack. Two copies of one skill would drift apart.control-cliandcontrol-uialso ship only incursor-team-kitand still have no fallback. They drive a real app, so a by-hand version wouldn't be the same thing.Verification
node scripts/validate-plugins.mjs,node scripts/generate-pstack-harness-trees.mjs --check, andnode scripts/check-pstack-docs.mjspass.node --test pstack/skills/*/scripts/test/*.test.mjspasses 148 of 150, with 2 skipped and 0 failed.git diff --checkis clean. The change is prose only, and pstack's version is not bumped.🤖 Generated with Claude Code
Note
Low Risk
Prose-only updates to skill and guide text; no runtime, auth, or data-handling changes.
Overview
Documents what agents should do when
cursor-team-kitis missing but poteto-mode still expects a pre-commit cleanup pass equivalent to/deslop.poteto-mode/SKILL.mdextends the “Before commit” trigger: without the plugin, the agent manually reviews the branch diff (behavior unchanged) and removes the same slop categories—extra comments, unnecessary guards/try/catch, type-checker casts, flattenable nesting, and code that doesn’t match local style.docs/guide/05-build-and-clean.mdaligns the user-facing guide: poteto-mode performs that hand pass; outside poteto-mode, users can still ask for the same cleanup in plain words.Reviewed by Cursor Bugbot for commit 2f9b5c5. Bugbot is set up for automated code reviews on this repo. Configure here.