Repository navigation
Conversation
A passing test count can hide a result that still violates the written contract. Name the acceptance surface, keep each commit green on its own, and let an explicit draft request override the ready default. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A delegate can report a green test count while the tree still violates the written contract. The playbooks now require the parent to read the diff against that contract, and they name a few neighboring gates that the same miss kept skipping.
What changed
Scope
Tradeoffs
One pull request, because the gates are one failure mode. Splitting them would make each sentence look like an unrelated style edit.
Blast Radius
Agents that follow these playbooks will refuse a green delegate report they have not checked, and they will keep a draft when the user asked for one. The installed plugin does not change until this lands.
Verification
node scripts/generate-pstack-harness-trees.mjs --checkpassed.node scripts/check-pstack-docs.mjsreported 0 problems.Made with Cursor
Note
Low Risk
Documentation-only changes to agent skill and playbook markdown; behavior shifts for agents following pstack, with no runtime or application code changes.
Reviewed by Cursor Bugbot for commit f7b884c. Bugbot is set up for automated code reviews on this repo. Configure here.