Skip to content

fix(pstack): check the contract, not a delegate's green count - #860

Open
julerex wants to merge 1 commit into
cursor:mainfrom
julerex:reflect/verify-against-contract
Open

julerex wants to merge 1 commit into
cursor:mainfrom
julerex:reflect/verify-against-contract

Conversation

@julerex

@julerex julerex commented Oct 24, 2026 •

Copy link
Copy Markdown

Why

A delegate can report a green test count while the tree still violates the written contract. The playbooks now require the parent to read the diff against that contract, and they name a few neighboring gates that the same miss kept skipping.

What changed

  • Feature verification names the acceptance surface, fails a narrower proxy, and re-runs the named checks after a delegate reports success.
  • Arena synthesis is the only implementer contract, and a long run copies that note into the decision trail.
  • Each commit has to be green with its own consumers. An explicit draft request overrides the ready default. An existing pull request is edited instead of duplicated.
  • Typed user entry and document-relative resolution stay on separate paths.

Scope

  • Covers the feature playbook, opening a pull request, arena, how, and three principle skills, plus the generated harness copies.
  • Leaves host-target isolation, read-only explorer enforcement, and a public-API caller check as mechanisms rather than more prose.

Tradeoffs

One pull request, because the gates are one failure mode. Splitting them would make each sentence look like an unrelated style edit.

Blast Radius

Agents that follow these playbooks will refuse a green delegate report they have not checked, and they will keep a draft when the user asked for one. The installed plugin does not change until this lands.

Verification

  • node scripts/generate-pstack-harness-trees.mjs --check passed.
  • node scripts/check-pstack-docs.mjs reported 0 problems.

Made with Cursor


Note

Low Risk
Documentation-only changes to agent skill and playbook markdown; behavior shifts for agents following pstack, with no runtime or application code changes.

Reviewed by Cursor Bugbot for commit f7b884c. Bugbot is set up for automated code reviews on this repo. Configure here.

A passing test count can hide a result that still violates the written
contract. Name the acceptance surface, keep each commit green on its
own, and let an explicit draft request override the ready default.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant