Skip to content

Stop a green smoke from closing an unmeasured device path - #861

Open
julerex wants to merge 1 commit into
cursor:mainfrom
julerex:reflect/ahci-session-lessons
Open

julerex wants to merge 1 commit into
cursor:mainfrom
julerex:reflect/ahci-session-lessons

Conversation

@julerex

@julerex julerex commented Oct 24, 2026 •

Copy link
Copy Markdown

Why

A guest smoke and a delegate clippy report closed a disk-controller design before the interrupt and the command path were measured. These workflow skills now say what has to be true before that close.

What changed

  • Feature work reproduces a red host check before design fan-out, and it writes the throughput checkpoint before delegates start.
  • A block or device driver is proved by the host render test and the guest serial log. Hardware delegates are reviewed for config-cycle width, message-signaled interrupt setup, and the command bit.
  • A green smoke does not cancel a contested design review. An existing pull request is updated instead of opened twice.
  • Arena disqualifies a candidate whose load-bearing claim fails a repo check, and the synthesis note is kept outside /tmp.
  • How measures an interrupt or device flag on the host when the docs and a probe can disagree.
  • A subagent success report is rerun by the parent.
  • The continuous-integration skill triggers on a red check during feature work.

Scope

  • Covers the workflow text those gates were missing.
  • Leaves enforcement of delegate type, disk-image refresh, and compiler crash files to the product tracker.

Verification

  • Diff review of the six skill files against the accepted reflect rows.

Made with Cursor


Note

Low Risk
Documentation-only changes to Cursor skill markdown; no runtime, auth, or application code paths.

Reviewed by Cursor Bugbot for commit 9eb149e. Bugbot is set up for automated code reviews on this repo. Configure here.

…vice path.

Co-authored-by: Cursor <cursoragent@cursor.com>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

Fix All in Cursor

Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.

Reviewed by Cursor Bugbot for commit 9eb149e. Configure here.

- **Shared mutable state.** Default to splitting the target (the **separate-before-serializing-shared-state** principle skill). Serialize only for real invariants.
- **Smallest safe decomposition.** If one worker is best, name why.

Write these four items before architect fan-out and before code delegates. A missing item is not a start.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feature gates run after design

Medium Severity · Logic Bug

The numbered Feature steps still run how and architect first, but the new checkpoint text tells the agent to reproduce a red host check and write the four items before those steps. Agents copy the steps in order, so the new gates run after design fan-out.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 9eb149e. Configure here.

**Commits.** Commit liberally. Rebase into small, ordered commits before opening PRs. Each commit is a future PR: landable, ordered to tell the story. Amend when the fix belongs in a just-made commit. New commit when separable. Commit bodies don't restate the subject.

**PRs.** Run `/deslop` from `cursor-team-kit` over the diff before commit and `/no-comments` before review. Write every PR title, description, and commit body with `/technical-writing` (every layer except Diátaxis, and apply the STE vocabulary rules: one word per action, keep articles, a plain verb over `-ing` where one works), then apply `/unslop`.
**PRs.** Before create, run `gh pr view` for the branch, or `gh pr list --head`. If a pull request already exists, push and edit its title and body. Do not open a second one. Run `/deslop` from `cursor-team-kit` over the diff before commit and `/no-comments` before review. Write every PR title, description, and commit body with `/technical-writing` (every layer except Diátaxis, and apply the STE vocabulary rules: one word per action, keep articles, a plain verb over `-ing` where one works), then apply `/unslop`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR check ignores Origin and OPEN

Medium Severity · Bugbot Rules

The new existence check runs only gh pr view or gh pr list --head and then edits whatever pull request it finds. That is the first PR operation, before forge resolution, so Origin-hosted work misses the existing pull request and opens a second one. gh pr view can also return a closed pull request and then block a new open. This drops forge-neutral Origin handling and the sole-OPEN preference.

Additional Locations (1)
Fix in Cursor Fix in Web

Triggered by learned rule: pstack PR playbooks stay forge-neutral

Reviewed by Cursor Bugbot for commit 9eb149e. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant