test(many-to-many): cover loading HasMany through ManyToMany - #577
Merged
Merged
Conversation
Regression test for #71: `load('posts.comments')` through a ManyToMany relation failed with "Undefined node" in ORM v1; on 2.x it works with JOIN, LEFT_JOIN and POSTLOAD. Assisted-By: Claude Opus 5.5
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 2.x #577 +/- ##
=========================================
Coverage 91.62% 91.62%
Complexity 2031 2031
=========================================
Files 132 132
Lines 5277 5277
=========================================
Hits 4835 4835
Misses 442 442 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
load('posts')->load('posts.comments'), checked withfetchData()andfetchAll()for JOIN, LEFT_JOIN and POSTLOAD.src/: the bug reported for ORM v1 ("Undefined node") does not reproduce on 2.x, and the test keeps it that way.Checklist