Skip to content

Render the STI children test through a real ORM Schema - #21

Open
roxblnfk wants to merge 1 commit into
1.xfrom
fix/16-sti-test-real-schema
Open

Render the STI children test through a real ORM Schema#21
roxblnfk wants to merge 1 commit into
1.xfrom
fix/16-sti-test-real-schema

Conversation

@roxblnfk

@roxblnfk roxblnfk commented Oct 5, 2026

Copy link
Copy Markdown
Member

🔍 What was changed

  • SingleTableInheritanceTest::testSchemaWithChildrenPropertyShouldBeRendered now builds a Cycle\ORM\Schema and converts it with SchemaToArrayConverter before rendering, like the other STI test; the TODO need fix and the commented-out assertion are gone.
  • The expected output follows the real schema: the block is titled by role ([user]) and the class is shown as Entity, instead of a class-keyed block with a Role line.

Checklist

@roxblnfk
test(STI): render the children test through a real ORM Schema
40206cb 
The test fed the raw array straight to the renderer since cycle/orm v1 support was dropped. A real Schema keys entities by role and moves the class into `Entity`, so the expected output now matches what the renderer gets in practice.

Fixes #16

Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix STI test for cycle/orm v1.8.1

1 participant

@roxblnfk