Skip to content

Julian/various fixes contd - #1437

Open
julian-CStack wants to merge 79 commits into
stagingfrom
julian/various-fixes-contd
Open

Julian/various fixes contd#1437
julian-CStack wants to merge 79 commits into
stagingfrom
julian/various-fixes-contd

Conversation

@julian-CStack

Copy link
Copy Markdown
Collaborator

duplicate of mistakenly closed #1436

# Conflicts:
#	pubspec.lock
#	scripts/app_config/templates/pubspec.template.yaml
- Explicit editable and canonical parsers, strict ASCII amount formatting, locale relocalization, and isolated IME recovery

- Wire existing formatters to their controllers
… fees. Validate it against base and priority fees, and use the same cap and gas limit for transaction construction and maximum-fee estimates.

- Localize custom fee input and reject malformed gas limits.
- parse scanned payment amounts canonically, preserve values across locale changes, validate nonce text, and keep displayed fees separate from editable controller text
…us rewrites, and locale changes. Parse exchange input through the shared editable layer while retaining the for-lack-of-a-better-option-currently existing 8 decimal policy
@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 30.45007% with 1978 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.71%. Comparing base (da38ddc) to head (abbe566).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
lib/pages/coin_control/coin_control_view.dart 0.00% 219 Missing ⚠️
.../coin_control/desktop_coin_control_use_dialog.dart 0.00% 134 Missing ⚠️
...eive_view/generate_receiving_uri_qr_code_view.dart 0.00% 114 Missing ⚠️
...ecific/coin_control/desktop_coin_control_view.dart 0.00% 101 Missing ⚠️
lib/pages/send_view/send_view.dart 0.00% 88 Missing ⚠️
...t/wallet_mixin_interfaces/electrumx_interface.dart 10.41% 86 Missing ⚠️
...exchange_view/exchange_step_views/step_2_view.dart 0.00% 78 Missing ⚠️
lib/pages/send_view/sol_token_send_view.dart 4.87% 78 Missing ⚠️
...ific/desktop_exchange/desktop_all_trades_view.dart 2.53% 77 Missing ⚠️
...ange/exchange_steps/subwidgets/desktop_step_2.dart 0.00% 77 Missing ⚠️
... and 64 more
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1437      +/-   ##
===========================================
+ Coverage     4.79%    6.71%   +1.91%     
===========================================
  Files         1109     1117       +8     
  Lines       111003   111758     +755     
===========================================
+ Hits          5325     7505    +2180     
+ Misses      105678   104253    -1425     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant