Skip to content

noVNC as real ESM, one module shape for every bundler #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
czpython merged 1 commit into from
Aug 17, 2026
Merged

noVNC as real ESM, one module shape for every bundler #271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"types:openapi": "openapi-typescript http://127.0.0.1:8000/openapi.json -o src/api/openapi.ts"
},
"dependencies": {
"@novnc/novnc": "1.5.0",
"@novnc/novnc": "1.7.0",
"@tanstack/react-query": "^5.101.4",
"lucide-react": "^1.27.0",
"react": "^19.2.8",
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/novnc.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
declare module '@novnc/novnc/lib/rfb' {
declare module '@novnc/novnc' {
export default class RFB extends EventTarget {
constructor(target: HTMLElement, url: string)
scaleViewport: boolean
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/LoginWindowPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const rfbState = vi.hoisted(() => ({
instances: [] as Array<EventTarget & { url: string; disconnect: ReturnType<typeof vi.fn> }>,
}))

vi.mock('@novnc/novnc/lib/rfb', () => {
vi.mock('@novnc/novnc', () => {
class FakeRFB extends EventTarget {
url: string
scaleViewport = false
Expand Down
2 changes: 1 addition & 1 deletion frontend/src/pages/LoginWindowPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useEffect, useRef, useState } from 'react'
import RFB from '@novnc/novnc/lib/rfb'
import RFB from '@novnc/novnc'

import { api } from '../api/client'
import { Page } from '../components/Page'
Expand Down