An expired credential reads as disconnected, not Connected - #273
Merged
czpython merged 1 commit intoAug 17, 2026
Merged
Conversation
The harness panel derived connection state from row-existence alone, so a credential whose token had expired still showed Connected with a past expiry date — disagreeing with druks doctor. HarnessResponse.from_row now compares expires_at to now, the same check doctor makes, so an expired credential reads as not connected and prompts a reconnect. Also shortens the settings rail item and pane heading from Browser sessions to Browser.
czpython
force-pushed
the
commonzenpython/eng-859-harness-panel-shows-connected-for-an-expired-token
branch
from
August 17, 2026 11:14
4221950 to
dd87168
Compare
czpython
enabled auto-merge (squash)
August 17, 2026 11:14
czpython
deleted the
commonzenpython/eng-859-harness-panel-shows-connected-for-an-expired-token
branch
August 17, 2026 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Settings → Services harness panel showed a Claude credential as Connected even after its token had expired, disagreeing with
druks doctor(which reported the same credential as expired).HarnessResponse.from_rowderived connection state from row-existence alone (bool(connection)), so any credential row read as Connected regardless ofexpires_at. This now applies the same expiry checkdoctormakes: a credential is connected only when it exists and is unexpired. An expired token reads as Not connected and prompts a reconnect.Also shortens the settings rail item and pane heading from Browser sessions to Browser.
Test
test_harness_card_reads_expired_token_as_not_connected— a pastexpires_atreportsconnected: false.Closes ENG-859.