Skip to content

feat(ux): hide visual close and clear symbols from screen readers - #619

Open
d-oit wants to merge 2 commits into
mainfrom
feat/ux-aria-hidden-close-symbols-2414128306498993854
Open

feat(ux): hide visual close and clear symbols from screen readers#619
d-oit wants to merge 2 commits into
mainfrom
feat/ux-aria-hidden-close-symbols-2414128306498993854

Conversation

@d-oit

@d-oit d-oit commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Wraps raw visual dismiss and clear text symbols (×) in KeyboardShortcutsModal, SearchSection, and History components inside to prevent screen readers from reading out "multiplication sign" or "times" alongside explicit aria-labels.


PR created automatically by Jules for task 2414128306498993854 started by @d-oit

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Sep 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
do-web-doc-resolover Ready Ready Preview Sep 11, 2026 11:12am UTC

@deepsource-io

deepsource-io Bot commented Sep 11, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 2b6ee94...e47c37d on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Sep 11, 2026 11:13a.m. Review ↗
Python Sep 11, 2026 11:13a.m. Review ↗
Rust Sep 11, 2026 11:13a.m. Review ↗
Shell Sep 11, 2026 11:13a.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@codacy-production

Copy link
Copy Markdown
Contributor

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant