Single-source dependency declarations through the DSL - #134
Open
JPDuchesne wants to merge 1 commit into
Open
Conversation
The declarations list is now the only data model: the GroupDSL/EnvDSL @brew/@envs shadow structures and Config#group are gone, and bin/install-build-deps.rb derives the container image's install list by filtering the same declarations the resolver/lockfile pipeline reads. Env-scoped brew now peels post_install and host onto the declaration like every other verb, and all dependency verbs work at the top level, landing in the default :app group like a top-level gem always has. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GroupDSL/EnvDSLno longer dual-write into@brew/@envsshadow hashes, andConfig#groupis gone.bin/install-build-deps.rbderives the container image's install list by filteringconfig.declarations(integration == :brew,group == :build, env/host filters mirroringDependencyInstaller).brewnow peelspost_installandhost:onto the declaration exactly like group-level verbs do (previously they leaked into the constraint hash on the env path).DependencyVerbsmodule) now work at the top level ofDev::Deps.define, landing in the default:appgroup — the same convention a top-levelgemalways followed.:appruntime default,:development/:test,:buildtoolchain materialized into build images, domain groups) and drops the dual-write description.Verification
ruby_versionverb) and fails identically under both.Made with Cursor