Repository navigation
feat(ui): watchlist keyed by security and closed-fund badge - #100
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Ported the shared UI blocks of
.claude/tools/etfs/ui-stdwithsecurities.ts(reference Neos #71):watchlist-key.tsx(ETF-C3): the Watchlist merges holdings by security (CUSIP, ISIN, FIGI, SEDOL, else ticker and name), never by ticker alone, so two companies that share a ticker in different funds stay apart; Copy Tickers copies each real ticker onceclosed-badge.tsx+closed.css(Q21): a closed fund keeps its row with aClosed <date>badge linking the source; the Fund Name filter and the search find it byclosedHow it was checked
bun run build,bun test(42 pass, 0 fail),git diff --check,.claude/tools/etfs/tc/check.sh(53 lines, same as main)dist, each0 failed; console errors: none:brand-uitest.ts(44 passed),columns-uitest.ts(19),categories-uitest.ts(19),clear-uitest.ts(19),security-uitest.ts(20)