feat: Add Windows ARM64 support - #1128
Conversation
- build.yml: add native windows-11-arm jobs (Qt 6.8/6.10, the only versions with ARM64 binaries), install Qt win64_msvc2022_arm64, use the arm64 VS environment, and upload/publish -arm64 artifacts - PackagingWindows.cmake: only ship the OpenSSL DLLs for x64 builds; ARM64 uses Qt's Schannel TLS backend - installer.nsi: only embed the OpenSSL DLLs when present in the package No C++ changes are required: as far as I know, the code and all thirdparty dependencies are architecture-neutral.
|
Seems to work fine. Demo video: |
|
Appreciate the PR and glad to see it is working and especially the installer! My one caution would be related to the application's auto-updater (which is the reason for the libcrypto dependency). Right now the application is pointed to check https://github.com/dail8859/NotepadNext/blob/master/updates.json which is just the x64 installer so the ARM version would end up pulling down the x64 installer and then fail to launch it. For the time being it may be preferrable to disable the auto-update feature on arm. I did also see that the QSimpleUpdater has a custom platform key that can be set here https://github.com/alex-spataru/QSimpleUpdater/blob/c5c136c0f79ca6423b0914a2676ae3d0e3811c5b/src/Updater.cpp#L350 and then that will force it to check for a new key rather than just "windows". |
|
We could just have it look for a download-url-arm64 key or something instead, and I think it would just update to that instead. |
3 participants
Solve #730