fix(config): use [metadata] section header in gittuf and hello TOMLs - #383
Merged
Marc-cn merged 1 commit intoAug 21, 2026
Merged
Conversation
Both plugin TOMLs used [framework] where FrameworkConfig requires [metadata], so both failed schema validation once the packaging fix made them loadable. Fixes darnitdevorg#361 Signed-off-by: Marco De Vincenzi <md6796@nyu.edu>
mlieberman85
approved these changes
Aug 21, 2026
mlieberman85
left a comment
Contributor
There was a problem hiding this comment.
Confirmed the fix locally:
- After checkout,
load_framework_by_name('gittuf').metadataandload_framework_by_name('hello').metadataboth return populatedFrameworkMetadatawith the expected name/display_name/version/spec_version. pytest tests/darnit_gittuf -q-- 21 pass.- No stragglers:
grep -rn '^\[framework\]' packages/ scripts/ docs/returns nothing after the change; baseline and reproducibility already use[metadata], so this brings gittuf and hello in line with the schema (FrameworkConfig.metadata: FrameworkMetadata, framework_schema.py:1477). - CI "Plugin discovery smoke (darnit-hello)" check is the equivalent of a hello test-suite here and it's green.
Two lines, right fix, closes #361 cleanly. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both plugin TOMLs used
[framework]whereFrameworkConfigrequires[metadata], so both failed schema validation once the packaging fix made them loadable.packages/darnit-gittuf/src/darnit_gittuf/gittuf.toml:1packages/darnit-hello/src/darnit_hello/hello.toml:16Two lines, header rename only.
Fixes #361
Type of Change
Framework Changes Checklist
If this PR modifies the darnit framework (
packages/darnit/):packages/darnit/, only two plugin TOMLsControl/TOML Changes Checklist
If this PR modifies controls or TOML configuration:
Testing
uv run ruff check .)Also confirmed directly:
uv run pytest tests/darnit_gittuf -qpasses. There is notests/darnit_hellodirectory.Additional Notes