Skip to content

feat(baseline): ruleset-aware branch-protection verdict (closes #343) #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mlieberman85 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(baseline): ruleset-aware branch-protection verdict (closes #343) #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .specify/feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"feature_directory": "specs/031-mcp-server-handler"}
{"feature_directory": "specs/032-ruleset-branch-protection"}
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,5 +381,5 @@ else:
<!-- SPECKIT START -->
For additional context about technologies to be used, project structure,
shell commands, and other important information, read the current plan:
[`specs/031-mcp-server-handler/plan.md`](specs/031-mcp-server-handler/plan.md)
[`specs/032-ruleset-branch-protection/plan.md`](specs/032-ruleset-branch-protection/plan.md)
<!-- SPECKIT END -->
2 changes: 2 additions & 0 deletions docs/architecture/framework-design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,6 +1116,8 @@ Project context from `.project/` SHALL be used to inform WHERE the sieve looks f

The framework SHALL provide a handler registry where handlers are registered by name with a phase affinity. Core SHALL register built-in handlers: `file_exists`, `exec`, `regex`, `llm_eval`, `manual_steps`, `file_create`, `api_call`, `project_update`. Implementations SHALL register domain-specific handlers via the existing `ComplianceImplementation.register_handlers()` method.

Implementation-registered sieve handlers (non-exhaustive): `github_branch_protection` (registered by `darnit-baseline`, encapsulates the classic-branch-protection + repository-rulesets two-surface check for `OSPS-AC-03.01`, `OSPS-AC-03.02`, `OSPS-QA-03.01`, `OSPS-QA-07.01`; see `specs/032-ruleset-branch-protection/contracts/github-branch-protection-handler.md`).

A handler used in a phase different from its registered affinity SHALL trigger a warning but still execute.

## Appendix C: Removed Requirements
Expand Down
Loading
Loading