Add webdev support for hot reload via the build daemon and a persistent Frontend Server - #2867
Open
Markzipan wants to merge 234 commits into
Open
Add webdev support for hot reload via the build daemon and a persistent Frontend Server#2867Markzipan wants to merge 234 commits into
Markzipan wants to merge 234 commits into
Conversation
…tion resets under high load
# Conflicts: # dwds_test_common/lib/fixtures/context.dart # webdev/CHANGELOG.md # webdev/lib/src/version.dart # webdev/pubspec.yaml # webdev/test/helpers/context.dart
…s_test_common to SDK
… proxy asset handler
github-actions
Bot
added
package:webdev
package:frontend_server_client
type-infra
Markzipan
changed the title
…d dependencies for build_runner daemon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes at a glance
Webdev (core)
dev_workflow.dart: Spawns a backgroundbuild_frontend_server:fes_managersubprocess whenwebHotReloadis enabled. TheFesManagermaintains a persistent shared Frontend Server instance (and scratch space) to handle expression evaluation, hot reload, and hot restart requests while coordinating with the build daemon.webdev_server.dart: ConfiguresFrontendServerBuildDaemonStrategyProviderwhenwebHotReloadis enabled. Writesfes_manager_configto signal tobuild_runnerthat a sharedFesManageris active.app_domain.dart: Can now handle hot reload requests viabuild_daemon.server_manager.dart: Now passesBuildDaemonClienttoWebDevServerto ensure build results are accessible towebdev.pubspec.yaml/pubspec_overrides.yaml: Add a dep overrides fordwdsanddwds_test_commonin the SDK.Webdev (tests)
webdev/test/helpers/context.dart:BuildDaemonTestContextandBuildDaemonAndFrontendServerTestContextfor testing withbuildDaemonandbuildDaemonAndFrontendServermodes.createBuildRunnerProxyHandler,_createBuildRunnerDdcLibraryBundleAssetHandler) to serve build outputs directly from the build cache and scratch space.webdev/test/:webdevto run againstBuildDaemonAndFrontendServerTestContext(split across AMD and DDC Library Bundle formats).CI
tool/ci.sh&mono_repo.yaml: Re-generated withmono_repo v6.7.2to support Linux Xvfb and headless Chrome execution (required for webdev to run tests that used to be indwdsanddwds_test_common)..github/workflows/): Updated permissions according to Zizmor guidance.Validation