fix: bind CoinJoin entry admission to session snapshot - #7599
Draft
PastaPastaPasta wants to merge 1 commit into
Draft
fix: bind CoinJoin entry admission to session snapshot#7599PastaPastaPasta wants to merge 1 commit into
PastaPastaPasta wants to merge 1 commit into
Conversation
PastaPastaPasta
force-pushed
the
fix/coinjoin-entry-session-snapshot
branch
from
August 13, 2026 06:07
c03f5d3 to
c9b90b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
CoinJoin entry validation performs chain and mempool work outside the session lock. During that work, the active session can reset or advance, and another entry can consume the same capacity or input. The validated entry could then be appended using a different session denomination or stale admission state.
This is intentionally a draft until #7596 lands. That PR makes the queue-to-entry transition participate in the same lock; this branch will then be rebased before review.
What was done?
cs_coinjoin, then append the entry in the same critical section.How Has This Been Tested?
test/test_dashwith depends on macOS arm64 using--enable-debug --enable-werror.coinjoin_inouts_tests(9 cases), including the new session-denomination regression test.coinjoin_tests(12 cases).Breaking Changes
None.
Checklist:
This pull request was created by Codex.