Repository navigation
ENH: add one_minus_square - #1051
Open
NeilGirdhar wants to merge 1 commit into
Open
NeilGirdhar wants to merge 1 commit into
NeilGirdhar wants to merge 1 commit into
Conversation
Compute `1 - x**2` as `(1 + x) * (1 - x)`, which avoids catastrophic cancellation when `|x|` is close to 1. On JAX >= 0.11.2, delegate to `jax.lax.one_minus_square`, whose derivative is defined as `-2x` and so stays accurate near zero. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compute
1 - x**2as(1 + x) * (1 - x), which avoids catastrophic cancellation when|x|is close to 1. On JAX >= 0.11.2, delegate tojax.lax.one_minus_square, whose derivative is defined as-2xand so stays accurate near zero.Reference issue
Closes #1050
AI Generation Disclosure
Yes, Claude. I reviewed the change. Please let me know if that's okay.