Repository navigation
Conversation
|
@dajiaohuang is attempting to deploy a commit to the data-driven-forms Team on Vercel. A member of the Team first needs to authorize it. |
rvsia
approved these changes
Oct 16, 2026
rvsia
left a comment
Contributor
There was a problem hiding this comment.
Thank you for the fixes! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Correct the custom-input examples so they can be used with
useFieldApiandFormRenderer:htmlForto associate the label with its input.useFieldApiexamples and spread the hook'sinputobject rather than an undeclaredrestvariable.The README schema and hook examples fail to parse as written. The README label also does not focus its input when clicked. These are documentation-only corrections; no library behavior or APIs change.
Validation
...placeholders when checking its JSX.useFieldApisnippets submit their expected dummy values after DOM input/click interactions. Supplied small local Card/Spinner/ErrorMessage components for the examples' custom imports.git diff --checkpasses.Limits: this was checked on Windows/Node 24 with an isolated core setup, not the documented Unix/Node 16 monorepo environment. The full monorepo build/lint/Jest suite and documentation-site build were not run. All browser data was synthetic and submissions were captured only by local callbacks; no external form endpoint was used.