cleanup: pre-release sweep#684
Open
parkan wants to merge 2 commits into
Open
Conversation
…c drift trivial real bugs: pure-go sqlite build dropped busy_timeout/foreign_keys pragmas (url.Values.Set clobber); Wrapf(nil) swallowed the CAR size-mismatch error; version nil-deref on missing build info; endpointfinder LruTimeout never set; compose init service lacked DATABASE_CONNECTION_STRING (migrated a throwaway sqlite, not the postgres); downloadserver logged ErrServerClosed as a failure; ClientConfig.String missing a field separator; deal duration default 12740h -> 12840h to match the cli. wrong printf verbs/args in log and error messages: %d on strings, %s on a bool, an undereferenced *string, reversed range args, wrong variable. dead code removed: store/item_reference.go blockstore, EmptyReadCloser, delegatedAddressToCommon, ChunkMapKeys, StoragePricePerEpochToPricePerDeal, healthcheck State, post-mysql retry strings, and other unreferenced symbols. per-file Info logs lowered to Debug on the scan/pack/piece-read hot paths. cli help text, user-facing typos, stale doc comments, and references to removed features (mysql, bitswap, encryption) corrected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grab-bag cleanup before 1.0.0 -- vet/staticcheck/gofmt were already clean, so this is all blind-spot stuff: wrong printf verbs, dead code (-583 lines), a few Info->Debug demotions on per-file hot paths, and stale docs/typos.
A handful of real one-liners in there worth a look: pure-go sqlite build was silently dropping the busy_timeout/foreign_keys pragmas (url.Values.Set clobber), Wrapf(nil) was eating a CAR size-mismatch, the version cmd nil-derefs when build info is missing, and compose init was migrating a throwaway sqlite instead of the postgres the other services use.
Second commit is the swagger/docs regen off those string changes -- no hand edits. Left the judgment-call items out (the pdp EAM-namespace check etc.), will raise those separately.