Repository navigation
feat(appkit): migrate files to modular @databricks/sdk-files - #638
Draft
MarioCadenas wants to merge 1 commit into
Draft
MarioCadenas wants to merge 1 commit into
MarioCadenas wants to merge 1 commit into
Conversation
Swap the facade's files accessor to a lazily built FilesClient (sdk-files 0.52.0, accepts sdk-core/auth/options 0.51.0). - list/download/createDirectory/delete use listDirectoryContentsIter, downloadFile, createDirectory, deleteFile; results are mapped back to the legacy snake_case / header-keyed shapes. - metadata uses a raw HEAD via request(): the generated getFileMetadata parses the empty HEAD body and drops the metadata headers. - Modular ApiError (httpStatusCode) is converted to the wrapper ApiError so exists() and the plugin's 4xx mapping keep working. - DirectoryEntry / DownloadResponse are now AppKit-owned types with the same shape. Co-authored-by: Isaac <no-reply@databricks.com> Signed-off-by: MarioCadenas <MarioCadenas@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the migration off
@databricks/sdk-experimentalonto the modular@databricks/sdk-*SDK (see #562). Base:feat/modular-sdk-integration.Changes
feat(appkit): migrate files to modular @databricks/sdk-files
Swap the facade's files accessor to a lazily built FilesClient
(sdk-files 0.52.0, accepts sdk-core/auth/options 0.51.0).
downloadFile, createDirectory, deleteFile; results are mapped back to
the legacy snake_case / header-keyed shapes.
parses the empty HEAD body and drops the metadata headers.
so exists() and the plugin's 4xx mapping keep working.
same shape.
Draft: implemented by an agent; needs review and a deployed SP + OBO check before it's marked ready.
This pull request and its description were written by Isaac.