Skip to content

direct: leave state closed when Open fails - #6330

Open
denik wants to merge 1 commit into
mainfrom
denik/dstate-open-reset
Open

direct: leave state closed when Open fails#6330
denik wants to merge 1 commit into
mainfrom
denik/dstate-open-reset

Conversation

@denik

@denik denik commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Open assigns db.Path before every fallible step, so a failed open left the receiver half-initialized: the next Open on the same value panicked with "state already opened" instead of reporting the real error.

Move the body into unlockedOpen and reset the receiver when it fails. Finalize reuses the same reset helper.

Open assigns db.Path before every fallible step, so a failed open left the
receiver half-initialized: the next Open on the same value panicked with
"state already opened" instead of reporting the real error.

Move the body into unlockedOpen and reset the receiver when it fails.
Finalize now shares the same reset helper.

Co-authored-by: Isaac
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: e66c0b2

Run: 32352085072

Env 🔄​flaky 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip Time
💚​ aws linux 1 4 274 1162 5:54
💚​ aws windows 1 4 276 1160 3:14
💚​ azure linux 1 4 273 1162 7:18
💚​ azure windows 1 4 275 1160 4:30
💚​ gcp linux 1 4 274 1162 5:47
🔄​ gcp windows 8 1 4 268 1160 4:54
13 interesting tests: 8 flaky, 4 SKIP, 1 RECOVERED
Test Name aws linux aws windows azure linux azure windows gcp linux gcp windows
💚​ TestAccept 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
🙈​ TestAccept/bundle/invariant/no_drift 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_endpoints/drift/recreated_same_name 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/bundle/resources/vector_search_indexes/recreate/embedding_dimension 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🙈​ TestAccept/ssh/connection 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
🔄​ TestFsCpFileToFileWithOverwriteFlag ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestFsCpFileToFileWithOverwriteFlag/local_to_uc-volumes ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestFsMkdirWhenDirectoryAlreadyExists ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestFsMkdirWhenDirectoryAlreadyExists/uc-volumes ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestFsMkdirWhenFileExistsAtPath ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestFsMkdirWhenFileExistsAtPath/uc-volumes ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestFilerRecursiveDelete ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
🔄​ TestFilerRecursiveDelete/files ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
Top 6 slowest tests (at least 2 minutes):
duration env testname
4:20 azure windows TestAccept
3:53 aws linux TestAccept
3:50 gcp linux TestAccept
3:48 azure linux TestAccept
3:10 gcp windows TestAccept
3:06 aws windows TestAccept

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants