clusters start: no-op when cluster isn't TERMINATED

.nextchanges/cli/clusters-start-already-running.md

@@ -0,0 +1 @@
+`databricks clusters start` no longer errors when the cluster is already RUNNING (or PENDING/RESTARTING/RESIZING). It now prints a short message and exits 0, matching the command's own help text ("If the cluster is not currently in a TERMINATED state, nothing will happen").

cmd/workspace/clusters/overrides.go

@@ -1,9 +1,12 @@
 package clusters
 
 import (
+	"errors"
+	"fmt"
 	"strings"
 
 	"github.com/databricks/cli/libs/cmdio"
+	"github.com/databricks/databricks-sdk-go/apierr"
 	"github.com/databricks/databricks-sdk-go/service/compute"
 	"github.com/spf13/cobra"
 )
@@ -93,8 +96,29 @@ func sparkVersionsOverride(sparkVersionsCmd *cobra.Command) {
 	`)
 }
 
+// The generated "start" command errors out (INVALID_STATE) if the cluster is
+// already RUNNING, PENDING, RESTARTING or RESIZING, even though the command's
+// own help text says "If the cluster is not currently in a TERMINATED state,
+// nothing will happen." This override makes the command match that
+// documented behavior instead of surfacing the API error.
+func startOverride(startCmd *cobra.Command, startReq *compute.StartCluster) {
+	originalRunE := startCmd.RunE
+	startCmd.RunE = func(cmd *cobra.Command, args []string) error {
+		err := originalRunE(cmd, args)
+
+		apiErr, ok := errors.AsType[*apierr.APIError](err)
+		if ok && apiErr.ErrorCode == "INVALID_STATE" {
+			fmt.Fprintf(cmd.OutOrStdout(), "Cluster %s is not in a TERMINATED state, nothing to do.\n", startReq.ClusterId)
+			return nil
+		}
+
+		return err
+	}
+}
+
 func init() {
 	listOverrides = append(listOverrides, listOverride)
 	listNodeTypesOverrides = append(listNodeTypesOverrides, listNodeTypesOverride)
 	sparkVersionsOverrides = append(sparkVersionsOverrides, sparkVersionsOverride)
+	startOverrides = append(startOverrides, startOverride)
 }

cmd/workspace/clusters/overrides_test.go

@@ -0,0 +1,45 @@
+package clusters
+
+import (
+	"bytes"
+	"errors"
+	"testing"
+
+	"github.com/databricks/databricks-sdk-go/apierr"
+	"github.com/databricks/databricks-sdk-go/service/compute"
+	"github.com/spf13/cobra"
+	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
+)
+
+func TestStartOverride_SwallowsInvalidStateError(t *testing.T) {
+	startReq := &compute.StartCluster{ClusterId: "1234-000000-abcdefg"}
+	cmd := &cobra.Command{}
+	cmd.RunE = func(cmd *cobra.Command, args []string) error {
+		return &apierr.APIError{ErrorCode: "INVALID_STATE", Message: "Cluster is in unexpected state Running."}
+	}
+
+	startOverride(cmd, startReq)
+
+	var out bytes.Buffer
+	cmd.SetOut(&out)
+	err := cmd.RunE(cmd, nil)
+
+	require.NoError(t, err)
+	assert.Contains(t, out.String(), startReq.ClusterId)
+}
+
+func TestStartOverride_PropagatesOtherErrors(t *testing.T) {
+	startReq := &compute.StartCluster{ClusterId: "1234-000000-abcdefg"}
+	cmd := &cobra.Command{}
+	wantErr := errors.New("boom")
+	cmd.RunE = func(cmd *cobra.Command, args []string) error {
+		return wantErr
+	}
+
+	startOverride(cmd, startReq)
+
+	err := cmd.RunE(cmd, nil)
+
+	assert.Equal(t, wantErr, err)
+}