Skip to content

Resolve job project-environment paths relative to bundle YAML - #6909

Closed
yiweidai-db wants to merge 4 commits into
databricks:mainfrom
yiweidai-db:stack/codex/bundle-project-environment
Closed

yiweidai-db wants to merge 4 commits into
databricks:mainfrom
yiweidai-db:stack/codex/bundle-project-environment

Conversation

@yiweidai-db

@yiweidai-db yiweidai-db commented Oct 1, 2026 •

Copy link
Copy Markdown

🥞 Stacked PR

Use this link to review incremental changes.


Changes

Superseded by #6983, which uses a branch in databricks/cli so the required CI jobs can run.

Resolve project_environment relative to the YAML file that defines it, using the existing file-path handling.

For project_environment: ../pyproject.toml in resources/job.yml, the Jobs API request changes from:

  • Before: ../pyproject.toml
  • After: /Workspace/.../files/pyproject.toml

This uses the same YAML-relative base as notebook_path.

Why

Jobs needs the uploaded project file's workspace path to read the environment. SDK and generated schema support already landed in #6928.

The deployment test uses the direct engine. The pinned Terraform provider still lacks this field.

Tests

  • 249 unit tests passed, including relative paths, absolute paths, source-linked deployments, and invalid paths.
  • Acceptance coverage passed for validation and Jobs create/update requests, with deployment history both enabled and disabled.
  • Scoped Go lint, formatting, and changelog validation passed.

Six existing path-test directories were blocked locally by jq 1.6; their pick() filters require jq 1.7+.

@yiweidai-db
yiweidai-db requested review from a team as code owners October 1, 2026 23:50
@github-actions github-actions Bot added the DABs DABs related issues label Oct 1, 2026
@yiweidai-db yiweidai-db changed the title Prepare bundle job project-environment path translation Test notebook-relative job project-environment paths Oct 1, 2026
@yiweidai-db yiweidai-db changed the title Test notebook-relative job project-environment paths Prepare YAML-relative job project-environment path translation Oct 2, 2026
@yiweidai-db
yiweidai-db force-pushed the stack/codex/bundle-project-environment branch from b609f9b to ac61e27 Compare October 6, 2026 17:49
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 6909
  • Commit SHA: ac61e27e4d6addbbb21785abfb00f7f29bea4f1e

Checks will be approved automatically on success.

@yiweidai-db yiweidai-db changed the title Prepare YAML-relative job project-environment path translation Resolve job project-environment paths relative to bundle YAML Oct 6, 2026
dyn.Key("tasks"),
dyn.AnyIndex(),
)
job := dyn.NewPattern(dyn.Key("resources"), dyn.Key("jobs"), dyn.AnyKey())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep original naming (job -> base) and formatting (one key per line) to minimize unnecessary diff?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denik opened a new PR on a branch opened in this repo. #6983

@yiweidai-db

Copy link
Copy Markdown
Author

Close this PR in favor of #6983

@yiweidai-db yiweidai-db closed this Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DABs DABs related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants