Repository navigation
acc: replace generic [NUMID] with targeted id replacements - #6975
Merged
Merged
Conversation
Co-authored-by: Isaac <no-reply@databricks.com>
Register per-run ids via replace_ids.py / read_id.py / add_repl in each test, plus a few scoped [[Repls]] (run ids, workspace object ids). Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/numid-targeted
branch
from
October 7, 2026 12:39
722af07 to
c07184f
Compare
…id from jobs create output Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…ids.py (Windows) Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 34a84f2
Top 18 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
October 7, 2026 16:04
denik
requested review from
a team,
jefferycheng1,
kanterov and
lennartkats-db
as code owners
October 7, 2026 16:04
Co-authored-by: Isaac <no-reply@databricks.com>
…uth.ResolveWorkspaceID, reuse create/list output for ids Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
pietern
approved these changes
Oct 8, 2026
| Successfully requested cancellation for run [NUMID] | ||
| Successfully requested cancellation for run [NUMID] | ||
| Successfully requested cancellation for run 334747067049496 | ||
| Successfully requested cancellation for run 566001814929041 |
Contributor
There was a problem hiding this comment.
Even if they're static, it would be nice to use replacements to set the right example.
Contributor
Author
There was a problem hiding this comment.
Not sure about this -- grepping the number I get exact point where it is coming from (test.toml [[Server]]). Grepping replacement I'd have one level of indirection there. We could use more memorable numbers, e.g. 111 and 222 but these ones are distinct enough.
| Old = '\?[ow]=\[WORKSPACE_ID\]' | ||
| New = '' | ||
| Order = 0 | ||
| Order = 1000 |
Contributor
There was a problem hiding this comment.
With the generic WORKSPACE_ID replacement, do we still need this repl to begin with?
Contributor
Author
There was a problem hiding this comment.
Yes — [WORKSPACE_ID] normalizes the value, but not whether the suffix is present. InitializeURLs only appends ?w=<id> when the id isn't already in the hostname (initialize_urls.go:85), so local/aws URLs get ?w=[WORKSPACE_ID] while azure/gcp vanity hosts (adb-<id>.…) have no suffix. The strip keeps one golden across all clouds; it now matches the placeholder and runs at Order 1000, after the harness literal.
denik
added a commit
that referenced
this pull request
Oct 8, 2026
Co-authored-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove the generic
\d{8,}→[NUMID]replacements fromacceptance/test.toml. Tests now name each id explicitly:replace_ids.py/read_id.py/add_replin scripts, plus a few scoped[[Repls]](run ids inbundle/integration_whl, workspace object ids inbundle/migrate). The harness adds a literal[WORKSPACE_ID](testserver constant locally,CurrentWorkspaceIDon cloud).UNIX_TIME_*patterns are anchored with\bso they no longer match inside longer ids.Why
[NUMID]hid which id is which, so a golden could not tell the job id from the run id, and a wrong or float-rounded id still passed.Tests
Full local acceptance suite regenerated and verified stable on a second run. Cloud-only goldens are not verified locally.
This pull request and its description were written by Isaac.