Repository navigation
Conversation
Collaborator
Integration test reportCommit: c0e686b
Top 6 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/bundle-struct-no-dyn
branch
from
October 8, 2026 07:52
67d1321 to
d49f829
Compare
denik
force-pushed
the
denik/structpath-build-not-parse
branch
from
October 8, 2026 07:52
7f56ac9 to
c0e686b
Compare
denik
force-pushed
the
denik/bundle-struct-no-dyn
branch
from
October 8, 2026 11:18
d49f829 to
b22dd28
Compare
Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/structpath-build-not-parse
branch
from
October 8, 2026 11:19
c0e686b to
5e82fbb
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
structpath.NewPattern(prev, parts...): the pattern counterpart ofNewPath, withstructpath.AnyKey(.*) andstructpath.AnyIndex([*]) wildcards.NoComputedStructpathParse: outside tests,MustParsePath/MustParsePattern/MustParsePathstake string literals only, andParsePath/ParsePatternmust not parse a formatted or concatenated string..agents/rules/style-guide-go.md.Why
Parsing a computed string re-validates what the code just built, allocates, and panics on keys with characters the parser reserves. Literals, tests and user input still parse.
Stacked on #6954. No behaviour change: rendered paths and patterns are identical.
This pull request and its description were written by Isaac.