Repository navigation
PyDABs: Pass --frozen to uv run so the Taskfile never rewrites uv.lock - #6987
Draft
janniklasrose wants to merge 2 commits into
Draft
janniklasrose wants to merge 2 commits into
janniklasrose wants to merge 2 commits into
Conversation
A plain `uv run` re-resolves and rewrites the committed uv.lock URLs to the internal *.databricks.com PyPI proxy whenever uv/pip is proxy-configured (locally or via setup-jfrog in CI). pydabs-codegen worked around this by reverting the lockfiles afterwards (`git checkout -- uv.lock codegen/uv.lock`). Pass `--frozen` to the five project `uv run` invocations (pydabs-test, pydabs-lint, pydabs-docs, and both pydabs-codegen calls) so uv consumes the committed lock as-is and never churns it, and drop the now-redundant revert. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 144a108
Top 6 slowest tests (at least 2 minutes):
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The PyDABs
uv runinvocations inpython/Taskfile.ymlnow pass--frozen, souv consumes the committed
uv.lockas-is instead of re-resolving. A plainuv runrewrites the lockfile's registry/package URLs to the internal*.databricks.comPyPI proxy whenever uv/pip is proxy-configured (locally, orvia setup-jfrog in CI), which surfaces as spurious
uv.lock/codegen/uv.lockdiffs.
pydabs-codegenpreviously papered over this by reverting the lockfiles aftergenerating (
git checkout -- uv.lock codegen/uv.lock); with--frozenthe churnnever happens, so that cleanup is dropped.
--frozenis applied to the five projectuv runcalls:pydabs-test,pydabs-lint(pyright),pydabs-docs, and bothpydabs-codegencalls. It isdeliberately not added to
uv lock --check(whose job is to detect a stalelock) or to the
--no-project/ lockless--scriptinvocations elsewhere (nolock to freeze). It matches the existing pattern for
internal/genkit/tagging.py,which already runs
uv run --frozen --script.Why
Running any PyDABs task in a proxy-configured shell left
uv.lockandcodegen/uv.lockdirty with proxy URLs — environment noise that could becommitted by accident.
--frozenfixes it at the source rather than revertingafter the fact.
Tests
Ran
pydabs-codegen,pydabs-docs, andpydabs-testin a proxy-configuredshell: all pass and leave the working tree clean (no lockfile churn), with no
change to generated output.
uv run --frozen pyrightruns clean too.pydabs-lintas a whole still stops at its pre-existinguv lock --checkstep,which fails on the proxy↔pypi.org URL mismatch — unrelated to this change.
This pull request and its description were written by Isaac.