Repository navigation
[AIGTWY-4977] Stub managed integration tests from JSON fixtures - #1032
Merged
Merged
Conversation
david-siqi-liu
force-pushed
the
david/managed-config-json-stubs
branch
3 times, most recently
from
October 7, 2026 21:08
5e1db72 to
6643a09
Compare
david-siqi-liu
force-pushed
the
david/cuj-skills-coverage
branch
from
October 7, 2026 21:08
e56e8ed to
f5fb31e
Compare
david-siqi-liu
marked this pull request as ready for review
October 7, 2026 21:38
david-siqi-liu
requested review from
AarushiShah-db,
lilly-luo and
rohita5l
as code owners
October 7, 2026 21:38
UG reviewThis test-only change replaces managed-config reads with JSON fixtures and removes two workspace credential paths from CI. The supplied diff is truncated, so the updated test helpers and assertions could not be fully reviewed. No actionable findings.
Automated advisory review of |
…xtures Integration tests now stub their config on the common managed workspace, while the e2e CUJs stay real and read-only. Each managed-config integration test loads its CodingAgentConfig from a checked-in JSON file in tests/fixtures/managed_config/ through UCODE_MANAGED_CONFIG_STUB. The files use the GET shape that `ug configure --file` (#866) accepts, so moving to --file later is mechanical. - Converted the inline builder configs (lifecycle, MCP, skills, models, smart routing, tracing) to fixtures. - Replaced the fetch-then-stub MPS discovery helper with fixtures. - Moved the published-config tests and the us-west-2 / ap-northeast-2 Claude defaults tests onto the managed workspace. - Dropped the extra workspaces' service principals and secrets, and the `managed` marker. Co-authored-by: Isaac <no-reply@databricks.com>
david-siqi-liu
force-pushed
the
david/managed-config-json-stubs
branch
from
October 7, 2026 22:56
6643a09 to
221a64c
Compare
andy-xu-db
approved these changes
Oct 7, 2026
david-siqi-liu
enabled auto-merge
October 7, 2026 23:16
lilly-luo
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion: #1026 (CUJ 2, 3 and 6 managed skills coverage). Independent PR; merge this one first, since it fixes the Managed config · Claude failure #1026 also sees.
Integration tests use a stubbed config on the common managed workspace, and the e2e CUJs stay real and read-only. Until now the managed integration suites mixed live published configs, three different workspaces with their own service principals, and configs built in Python. One of those workspaces (ap-northeast-2) began returning an empty
system.aicatalog, which turned Managed config · Claude red on every branch.Changes:
E2E_ADMIN_WORKSPACE). It gets its CodingAgentConfig from a checked-in JSON fixture intests/fixtures/managed_config/throughUCODE_MANAGED_CONFIG_STUB. The fixtures are in the GET shapeug configure --file([AIGTWY-4864] Support ug configure --file #866) accepts, so switching to--fileonce [AIGTWY-4864] Support ug configure --file #866 lands is mechanical.test_ug_configure_managed.py) now stub too. The stub records the samepublishedoutcome and TTL cache, so the TTL test still applies.eng-ml-inference-batch-inference-us-west-2oreng-ml-inference-ap-northeast-2. Their service principals,UG_MPS_DEFAULTS_CLIENT_SECRET,UG_PARENT_SCHEMA_DEFAULTS_CLIENT_SECRETand the runner's minting code are gone. Both repo secrets can be deleted once this merges.managedmarker is gone. Managed-config integration tests aremanaged_fixture.tests/e2e_cuj/) are untouched: they keep reading the real published workspace configs.tests/AGENTS.mdrule 4,tests/README.mdandtests/integration/README.mdare updated.This pull request and its description were written by Isaac.